Don't pass vmctx to component libcalls #10937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take a leaf out of the core libcalls book where the `from_vmctx` call is baked in as part of each libcall so libcalls can receive safer arguments by default. There's still much `unsafe` in the libcalls due to their arguments or accessing `*instance.store()`, but this latter part will be fixed in a follow-up commit soon.
d81804f to
18b4525
Compare
pchickey
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a leaf out of the core libcalls book where the
from_vmctxcall is baked in as part of each libcall so libcalls can receive safer arguments by default. There's still muchunsafein the libcalls due to their arguments or accessing*instance.store(), but this latter part will be fixed in a follow-up commit soon.