x64: Custom print logic #10918
Merged
x64: Custom print logic #10918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om processing logic. prtest:full
abrown
reviewed
Jun 4, 2025
Merged
Co-authored-by: Andrew Brown <andrew.brown@intel.com>
|
Ready for review, addressed feedback |
abrown
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Thanks! This looks good. I'll put this in the merge queue but if @alexcrichton has any further suggestions we could follow this up in the compare PR.
alexcrichton
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements custom print logic for
lockinstruction, and reworks the existing logic forcustom_visitto be more in the form of.custom(Visit | Display). Thecustom_visitlogic was originally implemented in #10887 and the changes are made based on some of these comments #10887 (comment)The
Displaylogic will be used for compare instructions as well.@abrown