More clearly flag internal crates as such #10963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is an attempt to more clearly flag internal crates in this project as internal and not intended for external use. Specifically: * Many crates are renamed from `wasmtime-foo` to `wasmtime-internal-foo`. * All of these crates now have `INTERNAL: ...` in their crates.io description. * All of these crates now have a warning at the top of their documentation discouraging use. This change is a result of rustsec/advisory-db#1999 where the goal is to be crystal clear from a project perspective that usage of these crates are highly discouraged and not supported. We'll still probably get such advisories but we won't be considering them CVEs from the project itself due to the internal nature of these crates and the discouraging warnings. Some concrete changes used here are: * Inter-crate dependencies still use `wasmtime_foo` for naming and do so with Cargo's package-renaming features. * Crate renames are specified at the workspace level so the rename is only in one locations and all other inherit it. * Contribution documentation now has some brief guidelines about crate organization.
This was referenced Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is an attempt to more clearly flag internal crates in this project as internal and not intended for external use. Specifically:
wasmtime-footowasmtime-internal-foo.INTERNAL: ...in their crates.io description.This change is a result of rustsec/advisory-db#1999 where the goal is to be crystal clear from a project perspective that usage of these crates are highly discouraged and not supported. We'll still probably get such advisories but we won't be considering them CVEs from the project itself due to the internal nature of these crates and the discouraging warnings.
Some concrete changes used here are:
wasmtime_foofor naming and do so with Cargo's package-renaming features.