Skip to content

Fix crash optimizing icmp with vectors #10948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Fix crash optimizing icmp with vectors #10948

merged 1 commit into from
Jun 6, 2025

Conversation

alexcrichton
Copy link
Member

Closes #10929

@alexcrichton alexcrichton marked this pull request as ready for review June 6, 2025 01:09
@alexcrichton alexcrichton requested review from a team as code owners June 6, 2025 01:09
@alexcrichton alexcrichton requested review from cfallin and dicej and removed request for a team June 6, 2025 01:09
@alexcrichton alexcrichton mentioned this pull request Jun 6, 2025
Closed
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language labels Jun 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

cfallin
cfallin approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@cfallin cfallin added this pull request to the merge queue Jun 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 6, 2025
@alexcrichton alexcrichton added this pull request to the merge queue Jun 6, 2025
Merged via the queue into bytecodealliance:main with commit 1541706 Jun 6, 2025
41 checks passed
@alexcrichton alexcrichton deleted the fix-icmp-vector-crash branch June 6, 2025 16:27
alexcrichton added a commit to alexcrichton/wasmtime that referenced this pull request Jun 6, 2025
@alexcrichton
Fix crash optimizing icmp with vectors (bytecodealliance#10948)
6bb4311 
Closes bytecodealliance#10929
@alexcrichton alexcrichton mentioned this pull request Jun 6, 2025
Merged
cfallin pushed a commit that referenced this pull request Jun 6, 2025
@alexcrichton
Fix crash optimizing icmp with vectors (#10948) (#10955)
550b304 
Closes #10929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

@dicej dicej Awaiting requested review from dicej dicej is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cranelift: unimplemented >64 bits error during bxor_not and icmp optimization
2 participants
@alexcrichton @cfallin