x64: Convert compare instructions to the new assembler
#10836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
abrown
reviewed
May 28, 2025
abrown
reviewed
Jun 2, 2025
17cbb3c to
71f52df
Compare
|
@abrown |
002e205 to
95df59e
Compare
abrown
reviewed
Jun 10, 2025
339b08d to
ee21774
Compare
abrown
added a commit
to abrown/wasmtime
that referenced
this pull request
Jun 11, 2025
Sometimes we just want to fix up the printed name of the instruction in the disassembly; e.g., instructions with the `lock` prefix. But, as we're seeing in bytecodealliance#10836 and elsewhere, other times we want to control the printing of the entire instruction--the full `Display` implementation. We'll need this kind of thing if we want to swap the order of operands or omit an immediate if it ends up being included in the printed instruction name. This change splits this kind of customization in two: `Mnemonic` and `Display`. After renaming this enum to `Customization`, all existing uses of `Display` are migrated to `Mnemonic`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
Sometimes we just want to fix up the printed name of the instruction in the disassembly; e.g., instructions with the `lock` prefix. But, as we're seeing in #10836 and elsewhere, other times we want to control the printing of the entire instruction--the full `Display` implementation. We'll need this kind of thing if we want to swap the order of operands or omit an immediate if it ends up being included in the printed instruction name. This change splits this kind of customization in two: `Mnemonic` and `Display`. After renaming this enum to `Customization`, all existing uses of `Display` are migrated to `Mnemonic`.
ee21774 to
cd27e90
Compare
|
@abrown ok i have rebased and pushed with changes, CI still running. |
f749f7c to
f0f1a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
compareinstructions.Implement
Eflagslogic for DSL and wire up isle rules to set flags when appropriate.