Update the definition of wasmtime::Memory
#10877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powered by the previous commit this change updates the internal implementation details of `wasmtime::Memory` to avoid the need for the use of `Stored`. This means that converting from a Wasmtime-internal representation of a memory to an external representation of a memory is largely a noop and no longer requires an allocation. This is intended to be more useful in the future to use the public types more pervasively inside of Wasmtime itself, but for now this is mostly the scaffolding necessary for such a change.
|
This is next up in the list from #10870 |
fitzgen
approved these changes
May 30, 2025
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jul 14, 2025
This adds `#[inline]` to some functions which are otherwise not available for cross-crate inlining. These functions started being more heavily used after historical refactorings such as bytecodealliance#10877 so this helps benchmarks which access linear memory in host functions, for example.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
This adds `#[inline]` to some functions which are otherwise not available for cross-crate inlining. These functions started being more heavily used after historical refactorings such as #10877 so this helps benchmarks which access linear memory in host functions, for example.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jul 16, 2025
This adds `#[inline]` to some functions which are otherwise not available for cross-crate inlining. These functions started being more heavily used after historical refactorings such as bytecodealliance#10877 so this helps benchmarks which access linear memory in host functions, for example.
alexcrichton
added a commit
that referenced
this pull request
Jul 16, 2025
This adds `#[inline]` to some functions which are otherwise not available for cross-crate inlining. These functions started being more heavily used after historical refactorings such as #10877 so this helps benchmarks which access linear memory in host functions, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Powered by the previous commit this change updates the internal implementation details of
wasmtime::Memoryto avoid the need for the use ofStored. This means that converting from a Wasmtime-internal representation of a memory to an external representation of a memory is largely a noop and no longer requires an allocation. This is intended to be more useful in the future to use the public types more pervasively inside of Wasmtime itself, but for now this is mostly the scaffolding necessary for such a change.