Skip to content

Conversation

benbrandt
Copy link
Member

@benbrandt benbrandt commented May 29, 2025

Remove references to deprecated cache config methods and update to use the new simplified Config::cache API. Also remove the mandatory enabled field from cache configuration documentation since all cache settings are now optional.

Follow-up to #10665

Remove references to deprecated cache config methods and update to use the new simplified `Config::cache` API. Also remove the mandatory `enabled` field from cache configuration documentation since all cache settings are now optional.
@benbrandt benbrandt requested review from a team as code owners May 29, 2025 14:18
@benbrandt benbrandt requested review from dicej and removed request for a team May 29, 2025 14:18
Copy link
Contributor

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dicej dicej added this pull request to the merge queue May 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2025
@alexcrichton alexcrichton added this pull request to the merge queue May 29, 2025
Merged via the queue into bytecodealliance:main with commit 0ffa745 May 29, 2025
41 checks passed
zshipko pushed a commit to extism/extism that referenced this pull request Jun 18, 2025
Hello,

I encountered an error when trying to enable caching in my project, I
could not compile any Plugins due to a bad configuration file used by
the wasmtime crate (`failed to parse config file`). I managed to find
understand the error after seeing [some changes made by
wasmtime](bytecodealliance/wasmtime#10859) and
its documentation. I was simply missing the `enabled` key from the
configuration, that has been removed from `wasmtime` (and its [cache
sister
crate](https://github.com/bytecodealliance/wasmtime/tree/main/crates/cache)).

So I added more information in the README regarding this specific issue,
and some extra behaviour that I noticed would happen regarding caching
configuration.

Hopefully this is helpful!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants