Update MSRV to 1.85.0 #10785
Merged
Update MSRV to 1.85.0 #10785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
approved these changes
May 16, 2025
This makes us eligible to update to the 2024 Rust edition but I'm planning on deferring that to a separate follow-up change. prtest:full
alexcrichton
commented
May 19, 2025
| @@ -114,7 +114,7 @@ impl TestFileCompiler { | |||
| unsafe extern "C" { | |||
| safe fn cosf(f: f32) -> f32; | |||
| } | |||
| let f = 1.2_f32; | |||
| let f = std::hint::black_box(1.2_f32); | |||
There was a problem hiding this comment.
Digging into this, it looks like LLVM sees in the assertion below assert_eq!(cosf(x), cosf(x)) and then LLVM has built-in knowledge that cosf is pure so it's optimized out entirely. That means libm doesn't get linked at all, meaning later dlsym calls fail.
Using black_box here is apparently enough, but unsure how long it'll last necessarily.
There was a problem hiding this comment.
For future posterity this is roughly what I was looking at. Basically we just need to preserve the reference to the cosf symbol. (and if anyone knows of a better way to do that let's definitely land that instead!)
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
May 19, 2025
Now possible after bytecodealliance#10785
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2025
Now possible after #10785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes us eligible to update to the 2024 Rust edition but I'm planning on deferring that to a separate follow-up change.