[s390x] Add full support for f128 #10774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds all missing operations to fully support f128 at the same level as f64 and f32 on s390x. The implementation is mostly a straightfoward extension of existing support, using the same vector instruction set. The exception is conversion between integer and f128, where we have to use the older floating-point instructions that use FPR register pairs to hold a f128 value. As regalloc does not support pairs, those registers are hard-coded, just as is done for the few instructions that require GPR register pairs.
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "isle"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
cfallin
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all missing operations to fully support f128 at the same level as f64 and f32 on s390x. The implementation is mostly a straightfoward extension of existing support, using the same vector instruction set. The exception is conversion between integer and f128, where we have to use the older floating-point instructions that use FPR register pairs to hold a f128 value. As regalloc does not support pairs, those registers are hard-coded, just as is done for the few instructions that require GPR register pairs.