c-api: new wasmtime_trap_new_code function #10765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e95f7fb to
78ea5b9
Compare
dotcarmen
commented
May 11, 2025
| @@ -129,7 +131,13 @@ public: | |||
| explicit Trap(std::string_view msg) | |||
| : Trap(wasmtime_trap_new(msg.data(), msg.size())) {} | |||
|
|
|||
| /// Returns the descriptive message associated with this trap | |||
| /// Creates a new trap with the given wasmtime trap code. | |||
| Trap(wasmtime_trap_code_enum code) | |||
There was a problem hiding this comment.
i'm not sure if this constructor signature is a good idea or if it's desired, i can change it if not :)
78ea5b9 to
388b3ff
Compare
There was a problem hiding this comment.
Thanks! Would you be up for sync-ing the implementation in C and Rust? The trap code listing here already doesn't match the Rust definition, so using from_u8 I don't think will work for the out-of-fuel trap for example. The convert-to-u8 can probably use trap as u8 nowadays, I'm not sure it was possible to do that when it was originally written. That should make the from_u8 conversion work as well.
Additionally would you be up for adding a test for this? Somewhere within this file is probably a good place to go.
61b2d25 to
e527e25
Compare
dotcarmen
commented
May 11, 2025
1cb87ae to
12b0870
Compare
12b0870 to
f6848b6
Compare
alexcrichton
approved these changes
May 13, 2025
f8e4c19 to
5e2dc3e
Compare
alexcrichton
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now, returning wasmtime-recognized traps from functions is only available to the Rust API. this PR adds a new function
wasmtime_trap_new_codeto the c api that returns a newwasm_trap_twith theTrapvalue associated with the given code.