Skip to content

Remove testing ONNX from CI #10411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

alexcrichton
Copy link
Member

This is blocking CI currently as a downloaded artifact is currently offline. This can be re-enabled once that's fixed.

This is blocking CI currently as a downloaded artifact is currently
offline. This can be re-enabled once that's fixed.
@alexcrichton alexcrichton requested a review from a team as a code owner March 17, 2025 18:36
@alexcrichton alexcrichton requested review from abrown and removed request for a team March 17, 2025 18:36
@alexcrichton
Copy link
Member Author

cc @abrown

@fitzgen fitzgen added this pull request to the merge queue Mar 17, 2025
Merged via the queue into bytecodealliance:main with commit 0d022c6 Mar 17, 2025
40 checks passed
@alexcrichton alexcrichton deleted the disable-onnx-testing branch March 17, 2025 20:16
alexcrichton added a commit to alexcrichton/wasmtime that referenced this pull request Mar 17, 2025
This is blocking CI currently as a downloaded artifact is currently
offline. This can be re-enabled once that's fixed.
alexcrichton added a commit that referenced this pull request Mar 17, 2025
* Add release notes for 31.0.0

* Remove testing ONNX from CI (#10411)

This is blocking CI currently as a downloaded artifact is currently
offline. This can be re-enabled once that's fixed.
abrown added a commit to abrown/wasmtime that referenced this pull request Mar 17, 2025
PR bytecodealliance#10411 disabled ONNX testing in CI due to failures to download ONNX
packages. This change restores that testing in hopes that any HTTP
related issues are now resolved.
@TrumsZ
Copy link
Contributor

TrumsZ commented Jun 16, 2025

Dear all,

Is there any update for re-enabling this test?

The reason why I ask above question is that currently, I failed to build the onnx feature through "cargo build --features component-model,wasi-nn,wasmtime-wasi-nn/onnx". It seems that wasmtime with version 32 or 33 are incompatible with neither the latest ort version v2.0.0-rc.10 nor ort version v2.0.0-rc.9.

Kind Regards,
Haiqing Zhao

@alexcrichton
Copy link
Member Author

Oh this is something we didn't track well and forgot about, but turning it back on is fine to happen at any time!

@TrumsZ
Copy link
Contributor

TrumsZ commented Jun 16, 2025

Hi @alexcrichton, thanks and nice to hear your quick response. I am looking forward to hearing your good news for turning it back on!

@TrumsZ
Copy link
Contributor

TrumsZ commented Jun 17, 2025

Hi @alexcrichton, by the way, since I’d like to test the ONNX feature, it would be great if you could share your schedule (when it is available) for turning it back on. Much appreciated!

@alexcrichton
Copy link
Member Author

Ah as with many things open source there's no strict schedule for things like this. Maintainers are frequently busy and this is free software so for things like this it can often be on you as a user to help out. Which is to say: no schedule, this may not happen unless it's contributed. You're of course welcome to file a PR yourself or file a dedicated issue about this to help track this.

@abrown
Copy link
Member

abrown commented Jun 17, 2025

@TrumsZ, can you open a PR to undo what this PR does? I'll help review it.

@TrumsZ
Copy link
Contributor

TrumsZ commented Jun 19, 2025

@abrown Yes, please take a lot for the PR #11071.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants