Skip to content

Trim wasm-pkg-common to allow targetting wasm32-wasip1 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Conversation

lann
Copy link
Collaborator

@lann lann commented Jun 19, 2025

Some collateral damage on this one:

  • Removed or made optional some wasm-pkg-common deps that don't build on wasm32-wasip1:
    • Replaced the wasm-pkg-common tokio feature flag with a broader registry-config flag which allows making more deps optional (notably etcetera)
    • Moved some functionality from wasm-pkg-common to wasm-pkg-client (the only place they were being used afaict): ContentDigest::sha256_from_file, RegistryMetadata::fetch*
  • Cleaned up CI while adding wasm32-wasip1 build check
    • Reorganized steps to check cheaper things earlier
    • Renamed _local feature flag to more descriptive docker-tests
  • Appease clippy

Fixes #162

@lann lann merged commit 91b374d into main Jun 19, 2025
6 checks passed
@lann lann deleted the common-wasm32 branch June 19, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow compiling to wasm32-wasip* targets
2 participants