Don't fail to print known custom sections #2264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `wasm-tools print` subcommand to print raw custom sections for some "known" custom sections if there is not printer registered for it. For example the `linking` and `reloc.CODE` custom sections are "known" but have no text format. Previously they would fail to print but now they will print the raw bytes.
pchickey
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
wasm-tools printsubcommand to print raw custom sections for some "known" custom sections if there is not printer registered for it. For example thelinkingandreloc.CODEcustom sections are "known" but have no text format. Previously they would fail to print but now they will print the raw bytes.