Skip to content

wasm-wave: Fix building with no-default-features #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

wasm-wave: Fix building with no-default-features #2263

merged 1 commit into from
Jul 28, 2025

Conversation

lann
Copy link
Contributor

@lann lann commented Jul 28, 2025

Depends on indexmap/std which is normally transitively enabled by wit-parser.

Fixes #2258

@lann
wasm-wave: Fix building with no-default-features
8ca4675 
Depends on `indexmap/std` which is normally transitively enabled by
wit-parser.
@lann lann requested a review from a team as a code owner July 28, 2025 12:58
@lann lann requested review from dicej and removed request for a team July 28, 2025 12:58
@alexcrichton alexcrichton added this pull request to the merge queue Jul 28, 2025
Merged via the queue into bytecodealliance:main with commit 3a207bd Jul 28, 2025
34 checks passed
@lann lann deleted the fix-wave-no-default-features branch July 28, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@dicej dicej Awaiting requested review from dicej dicej is a code owner automatically assigned from bytecodealliance/wasm-tools-default-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasm-wave cannot build with default-features = false
2 participants
@lann @alexcrichton