fix: added musl builds x86_64 and aarch64 #2259
Conversation
Signed-off-by: Thomas Timmer <thomastimmer11@hotmail.com>
|
ah I see it uses wasm-tools (I though it would use wasmtime) to get the builder docker images |
|
Ah yeah the Wasmtime action in-use here basically just builds some Docker containers in |
|
|
||
| RUN apt-get update -y && apt-get install -y ninja-build | ||
| RUN git config --global --add safe.directory '*' | ||
| ENV EXTRA_RUSTFLAGS=-Ctarget-feature=-crt-static |
There was a problem hiding this comment.
This is a bit different from Wasmtime in that EXTRA_RUSTFLAGS isn't recognized in this repository, could this be updated to RUSTFLAGS and/or could EXTRA_RUSTFLAGS get handled? (as-is static binaries are produced when it's intended that dynamic binaries are produced instead)
There was a problem hiding this comment.
updated both to use RUSTFLAGS instead
There was a problem hiding this comment.
reverted back to EXTRA_RUSTFLAGS
|
Bah static binaries are still popping out. I believe the reason for that is that the wrapper script here will by default inherit rustflags from the calling process (which for CI is |
This reverts commit 9ff1f40.
#2257
The build are copied from https://github.com/bytecodealliance/wasmtime/blob/v29.0.1/ci/build-build-matrix.js
I see it uses version 28.0 but I don't see aarch64-musl in that tag. However in 29.0 I dont see the 'bytecodealliance/wasmtime/.github/actions/binary-compatible-builds@release-28.0.0' workflow anymore 🤔