wasm-tools print: add option to print operand stack between instructions #2251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
294eddb to
a67f457
Compare
This prints the operand stack types within function bodies,
flagging newly pushed operands when color output is enabled. E.g.:
```wasm
(module
(type (;0;) (func))
(func (;0;) (type 0)
i32.const 4
;; [i32]
i32.const 5
;; [i32 i32]
i32.add
;; [i32]
drop
;; []
)
)
```
a67f457 to
405f3c3
Compare
Minimize the `#[cfg]` in the "main code" by avoiding it entirely and instead switching between two modules at compile time. Preserve the property of not needing the validator when this feature is disabled, however.
|
This is awesome, thank you so much for implementing this! Overall this looks great and the points I'd comment on are mostly Rust-related so I went ahead and sketched them out and PR'd as keithw#2. Notably I personally prefer to cut down on |
|
That's a nice technique! Thanks, merged your PR. |
alexcrichton
approved these changes
Jul 1, 2025
|
This is fantastic!! Thanks so much @keithw!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1381 (mentioned in #2235 (comment))
Example output: