partially revert future.{read,write} ABI changes
#2229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After Luke, Alex, and I reviewed the implementation details across `wasm-tools`, `wit-bindgen`, and `wasip3-prototyping`, we concluded that passing up to 4 flat parameters to `future.write` and removing the address param for no-payload `future.read` functions were both more trouble than they were worth. This reverts those changes, meaning we're back to the original ABI except that the `memory` parameter is optional for no-payload futures. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Luke, Alex, and I reviewed the implementation details across
wasm-tools,wit-bindgen, andwasip3-prototyping, we concluded that passing up to 4 flat parameters tofuture.writeand removing the address param for no-payloadfuture.readfunctions were both more trouble than they were worth.This reverts those changes, meaning we're back to the original ABI except that the
memoryparameter is optional for no-payload futures.