Revise MSRV policy for this repository #2199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In writing the current policy for this repository's minimum supported version of Rust (MSRV) is "stable minus two" which matches Wasmtime. This does not reflect the current reality, however, where the current MSRV is 1.76 where the current Rust is 1.87. This additionally does not reflect what I think is the best decision for this repository. While "stable minus two" matches Wasmtime this repository is expected to be possibly used in more contexts than Wasmtime, for example any wasm-processing tools which can be lower-level than anything needing a wasm runtime. Given all this the change here is to update the comments on MSRV policy for this repository to "stable minus 10, not proactively updated". That is a much larger window of Rust but the code in this repository is much less likely than Wasmtime, for example, to benefit from newer features of Rust. The hope is that this won't be too onerous to maintain while still allowing to eventually use newer features as necessary.
174dbb2 to
fcd4fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In writing the current policy for this repository's minimum supported version of Rust (MSRV) is "stable minus two" which matches Wasmtime. This does not reflect the current reality, however, where the current MSRV is 1.76 where the current Rust is 1.87. This additionally does not reflect what I think is the best decision for this repository. While "stable minus two" matches Wasmtime this repository is expected to be possibly used in more contexts than Wasmtime, for example any wasm-processing tools which can be lower-level than anything needing a wasm runtime.
Given all this the change here is to update the comments on MSRV policy for this repository to "stable minus 10, not proactively updated". That is a much larger window of Rust but the code in this repository is much less likely than Wasmtime, for example, to benefit from newer features of Rust. The hope is that this won't be too onerous to maintain while still allowing to eventually use newer features as necessary.