Fix parsing of identifiers in type contexts #2195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a historical bug the `wast` crate when parsing `$id`-style identifiers in exports within a type context (e.g. within an instance type or a component type). This was due to what I believe was a historical misunderstanding of mine and/or maybe some historical change, unsure! This is a breaking change for the text format but given how rarely this should be used it's expected that this breaking change practically won't actually have any impact. Closes bytecodealliance#2192
fitzgen
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a historical bug the
wastcrate when parsing$id-style identifiers in exports within a type context (e.g. within an instance type or a component type). This was due to what I believe was a historical misunderstanding of mine and/or maybe some historical change, unsure!This is a breaking change for the text format but given how rarely this should be used it's expected that this breaking change practically won't actually have any impact.
Closes #2192