Improve time complexity of handling large WIT types #2167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update a few places in tooling which iterate over the structure of a WIT type to contain early-returns or similar to ensure that processing these large types doesn't take an exponential amount of time. Closes bytecodealliance#2164
|
cc @cpetig |
alexcrichton
commented
Apr 29, 2025
Comment on lines
+3
to
+6
| // TODO: this should use "FAIL" and should actually be a test, but this | ||
| // currently takes too long to run and the long runtime is in and of itself a | ||
| // bug. | ||
| // fail[abi]: component embed --dummy % | component new |
There was a problem hiding this comment.
This is an interesting test where the test below actually fits in the flat representation, unlike all of the above tests which don't fit flat. This test takes quite a long time to produce the flat representation.
This isn't a problem for validation since this type is "too large and complex" and fails validation before we get to the flat representation, but is still an issue for tooling which I'm not sure how best to handle.
pchickey
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update a few places in tooling which iterate over the structure of a WIT type to contain early-returns or similar to ensure that processing these large types doesn't take an exponential amount of time.
Closes #2164