Skip to content

feat(wasm-encoder, wasmparser): replace f32 / f64 with Ieee32 / Ieee64 #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

feat(wasm-encoder, wasmparser): replace f32 / f64 with Ieee32 / Ieee64 #2157

merged 1 commit into from
Apr 24, 2025

Conversation

StackOverflowExcept1on
Copy link
Contributor

Resolves #2155

alexcrichton
alexcrichton approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I agree this is the best path for now. I also agree longer-term it'd be good to unify types in a crate, but it's best to leave that for future plans at this juncture.

@alexcrichton alexcrichton added this pull request to the merge queue Apr 24, 2025
Merged via the queue into bytecodealliance:main with commit 71feb9e Apr 24, 2025
32 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the floats branch April 24, 2025 18:14
@BrewTestBot BrewTestBot mentioned this pull request May 5, 2025
Merged
@michaelficarra michaelficarra mentioned this pull request Jul 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasm-encoder: add option to disable float instructions
2 participants
@StackOverflowExcept1on @alexcrichton