Throw out some wit-smith generated documents after #2138 #2141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
approved these changes
Apr 14, 2025
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Apr 15, 2025
This commit fixes another fuzz bug after bytecodealliance#2141 didn't actually fix other variations of the original bug. The fix here is to ensure that the creation of `[method]name.name` basically just isn't possible because if `name` is present, which is required for resources, then `[method]name.name` is not allowed to be present.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
This commit fixes another fuzz bug after #2141 didn't actually fix other variations of the original bug. The fix here is to ensure that the creation of `[method]name.name` basically just isn't possible because if `name` is present, which is required for resources, then `[method]name.name` is not allowed to be present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now some previously-valid WIT packages are considered invalid, so just throw out such test cases instead of keeping them.