Require [..]l.l is not present with l
#2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates validation of component model names to account for WebAssembly/component-model#494. This technically affects all existing users as well but it's hoped that it won't actually hit any cases of this in the wild.
This was referenced Apr 11, 2025
|
LGTM, I am not super familiar with this code but changes look sane to me |
pchickey
approved these changes
Apr 11, 2025
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates validation of component model names to account for WebAssembly/component-model#494. This technically affects all existing users as well but it's hoped that it won't actually hit any cases of this in the wild.