Skip to content

add subtask.cancel intrinsic #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

dicej
Copy link
Collaborator

@dicej dicej commented Apr 10, 2025

This has not yet been added to the spec, but we've got a general idea of how it will look and behave: WebAssembly/component-model#495

Note that, since there's not spec for it yet, I've picked the next unused binary discriminant in the sequence: 0x24. That should be easy enough to change if necessary once the spec is updated.

@dicej dicej requested a review from alexcrichton April 10, 2025 21:03
@alexcrichton
Copy link
Member

Mind adding some tests for this as well? For example wit-component tests that the import gets hooked up in addition to *.wast tests that it validates and has the right signature and such

@dicej dicej force-pushed the subtask-cancel branch 3 times, most recently from 9e11f22 to 0545245 Compare April 10, 2025 21:59
This has not yet been added to the spec, but we've got a general idea of how it
will look and behave: WebAssembly/component-model#495

Note that, since there's not spec for it yet, I've picked the next unused binary
discriminant in the sequence: 0x24.  That should be easy enough to change if
necessary once the spec is updated.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@alexcrichton alexcrichton added this pull request to the merge queue Apr 10, 2025
Merged via the queue into bytecodealliance:main with commit f337f82 Apr 10, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants