wast: ignore multiple start sections (already detected in wasmparser) #2133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wast crate has a
validate
function (onWat
s,Module
s andComponent
s), but:parse
calls it, but Moduleparse_without_module_keyword
and Componentparse_without_component_keyword
don't call it, and those are used instead for some of the wast directives -- this led to some confusing debugging!)wasmparser
is also capable of detecting)This PR eliminates the
validate
function and defers detection of the error to the binary format.