wast.rs: Validate, roundtrip and snapshot "unlinkable" modules #2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for the
assert_unlinkablecases in the spec testsuite.These are valid modules, so this PR makes the
wastsubcommand treat them the same as amoduledeclaration (i.e. validate, roundtrip, and snapshot). There are some tests in the testsuite that useassert_unlinkableto test extreme (valid) modules without causing the test runner to actually instantiate a gigantic module (e.g. https://github.com/WebAssembly/custom-page-sizes/blob/main/test/core/custom-page-sizes/memory_max.wast), so it would be good to have wasm-tools run these test cases through the validator instead of ignoring them.Treating them like a
moduleseems the most consistent, but the snapshots are a lot of new files in the repo and I'm not sure they're totally necessary. We could also just validate and roundtrip without the snapshot.This is part of the "malformed-invalid separation + roundtrip invalid" patchset (https://github.com/keithw/wasm-tools/tree/malformed-invalid-separation).