Skip to content

Define component names subsection for core tag names #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

keithw
Copy link
Contributor

@keithw keithw commented Mar 28, 2025

This allows components with named core tags to be roundtripped through the binary format.

0x04 is already allocated as CORE_TAG_SORT in https://github.com/WebAssembly/component-model/blob/main/design/mvp/Binary.md#name-section

This allows components with named core tags to be roundtripped
through the binary format.
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame on me for trying to skip tests :(

@alexcrichton alexcrichton added this pull request to the merge queue Mar 28, 2025
Merged via the queue into bytecodealliance:main with commit 20e2eec Mar 28, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants