Add wasm-module
to wast
dependency
#2098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unfortunate series of events which renders most historical builds of
wasm-tools
un-buildable from crates.io without--locked
. The basic problem here is of this shape:wasm-tools
CLI requires thewasm-module
feature to be enabled inwast
but doesn't explicitly enable it.wasm-tools
crate depends onwat
, which by default enables this feature. This is why everything "works" today.wat
crate has semver-compatible releases, meaning that a historicalwasm-tools
may pull in a newerwat
.wasm-tools
pulls in a newerwat
then it'll activate thewasm-module
dependency in a different version ofwast
, meaning the CLI doesn't have the feature enabled in its dependency ofwast
.I'm not sure how it would be possible to detect this on CI and fix this or otherwise have a check against it. Thankfully using
--locked
at least for historical builds works (but that shouldn't be required).