Gate some async features behind separate feature gates #2095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an implementation of WebAssembly/component-model#468 in this repository. This also takes a moment to rename some `component-model-*` feature names to `cm-*` to avoid being so wordy. Additionally this renumbers some features to compress the bit space being used.
fitzgen
approved these changes
Mar 11, 2025
dicej
approved these changes
Mar 11, 2025
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Mar 12, 2025
I meant to hold off merging bytecodealliance#2095 until WebAssembly/component-model#468 was finished but I forgot and merged it anyway. This commit updates the implementation in wasmparser's validation with the result of some discussion on that upstream PR.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
I meant to hold off merging #2095 until WebAssembly/component-model#468 was finished but I forgot and merged it anyway. This commit updates the implementation in wasmparser's validation with the result of some discussion on that upstream PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of WebAssembly/component-model#468 in this repository. This also takes a moment to rename some
component-model-*feature names tocm-*to avoid being so wordy. Additionally this renumbers some features to compress the bit space being used.