Enhance dummy async module generation #2084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the `--async-callback` and `--async-stackful` arguments to the `wasm-tools component embed` subcommand when paired with `--dummy-names legacy`. Specifically the dummy module generated now additionally includes imports for various component model intrinsics such as waitable-set management, future management, `task.return`, etc. The goal of this commit is to stress `wit-component`'s processing of these intrinsics during normal fuzzing. After the dummy module support was updated the `roundtrip_wit` fuzzer was run locally for awhile and a number of bugs popped out. This commit additionally includes various fixes and test cases. All tests "pass" before this commit because intrinsics weren't generated in dummy mode, but tests all fail without the `wit-component` fixes but with the dummy module support.
|
My plan is to make a point release after this is merged. |
This was referenced Mar 7, 2025
dicej
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the
--async-callbackand--async-stackfularguments to thewasm-tools component embedsubcommand when paired with--dummy-names legacy. Specifically the dummy module generated now additionally includes imports for various component model intrinsics such as waitable-set management, future management,task.return, etc. The goal of this commit is to stresswit-component's processing of these intrinsics during normal fuzzing.After the dummy module support was updated the
roundtrip_witfuzzer was run locally for awhile and a number of bugs popped out. This commit additionally includes various fixes and test cases. All tests "pass" before this commit because intrinsics weren't generated in dummy mode, but tests all fail without thewit-componentfixes but with the dummy module support.