Refactor/improve parsing of component canonical text format #2069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is an improvement and refactoring to the parsing of
(canon ...)
forms in the text format for components. Previously there was a large amount of duplication to handle the short-hand form of:and the long-hand form of
This commit removes this duplication and in the process fixes support for the long-hand format of
(canon ...)
. This is not heavily used in tooling of this workspace but it's mentioned in the specification and should likely be supported regardless.