Skip to content

Conversation

alexcrichton
Copy link
Member

This commit is an improvement and refactoring to the parsing of (canon ...) forms in the text format for components. Previously there was a large amount of duplication to handle the short-hand form of:

(core func (canon ...))

and the long-hand form of

(canon ... (core func))

This commit removes this duplication and in the process fixes support for the long-hand format of (canon ...). This is not heavily used in tooling of this workspace but it's mentioned in the specification and should likely be supported regardless.

@alexcrichton alexcrichton requested a review from dicej February 24, 2025 20:47
This commit is an improvement and refactoring to the parsing of `(canon
...)` forms in the text format for components. Previously there was a
large amount of duplication to handle the short-hand form of:

```
(core func (canon ...))
```

and the long-hand form of

```
(canon ... (core func))
```

This commit removes this duplication and in the process fixes support
for the long-hand format of `(canon ...)`. This is not heavily used in
tooling of this workspace but it's mentioned in the specification and
should likely be supported regardless.
@alexcrichton alexcrichton added this pull request to the merge queue Feb 27, 2025
Merged via the queue into bytecodealliance:main with commit e4c33fc Feb 27, 2025
31 checks passed
@alexcrichton alexcrichton deleted the refactor-parsing-canonicals branch February 27, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants