Add codegen option for including source #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/cli/src/commands.rs
Outdated
Comment on lines
214
to
216
| /// Enable source code compression, which generates smaller WebAssembly | ||
| /// files at the cost of increased compile time. | ||
| SourceCompression(bool), |
There was a problem hiding this comment.
Could you update the documentation to reflect that this flag will be a no-op in case -source=n?
crates/cli/src/commands.rs
Outdated
Comment on lines
212
to
213
| /// Embed the JavaScript source in the generated WebAssembly module. | ||
| Source(bool), |
There was a problem hiding this comment.
Suggested change
| /// Embed the JavaScript source in the generated WebAssembly module. | |
| Source(bool), | |
| /// Embed the JavaScript source in custom section the generated WebAssembly module. | |
| Source(bool), |
jeffcharles
reviewed
Aug 28, 2025
crates/codegen/src/lib.rs
Outdated
| @@ -159,7 +159,9 @@ pub struct Generator { | |||
| pub(crate) plugin: Plugin, | |||
| /// What kind of linking to use when generating a module. | |||
| pub(crate) linking: LinkingKind, | |||
| /// Whether to embed the compressed JS source in the generated module. | |||
| /// Whether to embed the JS source in the generated module. | |||
| pub(crate) source: bool, | |||
There was a problem hiding this comment.
Specifically in the codegen crate, can we make source an enum with three options: omitted, compressed, and uncompressed and remove the source_compression field?
I think that would make more sense that two booleans given there's only three states and we're going to be releasing a new major version for the crate soon anyway so a breaking change is fine.
|
You'll need to run |
jeffcharles
approved these changes
Aug 28, 2025
|
Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a codegen option that allows for opting out of the
javy_sourcecustom section. If-C source=nis specified to the CLI,source-compressionhas no effect.Fixes #982
Why am I making this change?
Allows for smaller Wasm modules output by Javy in case the source code is not necesary. Through local testing I was able to shrink my Wasm modules by about one third.
Checklist
javy-cli,javy-plugin, andjavy-plugin-processingdo not require updating CHANGELOG files.