Skip to content

Conversation

T45K
Copy link
Contributor

@T45K T45K commented Sep 23, 2020

Description

In #2771, HttpUrlFetcher#loadData was refactored (here), but its similar method, AssetPathFetcher#loadData was not modified.
I thought the modification is needed for consistency.

Motivation and Context

This PR makes this project stay consistent.

@sjudd
Copy link
Collaborator

sjudd commented Sep 23, 2020

Thanks. I don't have super strong opinions one way or another, but there are several other places where we follow the pattern you're refactoring away from:

Do you want to make this change across all of these similar implementations?

@T45K
Copy link
Contributor Author

T45K commented Sep 23, 2020

@sjudd Thank you for your comment.

I have now requested access to the document.
As soon as the access rights are granted, I'll start the modification.

@sjudd
Copy link
Collaborator

sjudd commented Sep 23, 2020

Ugh sorry, wrong link, here's the right one:

@T45K
Copy link
Contributor Author

T45K commented Sep 24, 2020

@sjudd

I've modified all loadData methods which have try-catch statement
Would you check again?

@sjudd
Copy link
Collaborator

sjudd commented Sep 24, 2020

Thanks!

@sjudd sjudd added import-ready Indicates the PR is ready to be imported to Google. enhancement labels Sep 24, 2020
@copybara-service copybara-service bot merged commit 9c6eae7 into bumptech:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes enhancement import-ready Indicates the PR is ready to be imported to Google.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants