fix(overlay): make sure to keep track of overlay $refs #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cff9e38 to
291aa2f
Compare
fbraure
approved these changes
Jul 17, 2025
4413d4b to
28b984b
Compare
This commit is a fix to be able to keep track of references ($ref) used inside an overlay. This make it possible to use an overlay which references external files, and have them available for the main (overlayed) definition. Thanks @JakeSCahill for noticing the bug!
28b984b to
339346e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a fix to be able to keep track of references ($ref)
used inside an overlay. This make it possible to use an overlay which
references external files, and have them available for the
main (overlayed) definition.
Thanks @JakeSCahill for noticing the bug!