Better error logging for the LNURL endpoint #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks for errors when creating the invoice and logs the error and returns an LNURL error response. Before it would return a blank pr.
|
Do you think this is this enough? @joostjager |
this also registers a shorter lnurlp that can be used additionally to the lightning address
joostjager
reviewed
Oct 24, 2021
| return c.JSON(http.StatusOK, lnurl.LNURLErrorResponse{Status: "ERROR", Reason: "Invalid Amount"}) | ||
| } | ||
| sats := msats / 1000 // we need sats | ||
| metadataHash := sha256.Sum256([]byte(lnurlMetadata)) | ||
| invoice, err := lnClient.AddInvoice(sats, lightningAddress, metadataHash[:]) | ||
| if err != nil { | ||
| stdOutLogger.Printf("Error creating invoice: %s", err) | ||
| return c.JSON(http.StatusOK, lnurl.LNURLErrorResponse{Status: "ERROR", Reason: "Server Error"}) |
There was a problem hiding this comment.
IMO not, but I think that's how LNURL wants the response?
edit: I only found a comment now that LNURL does not care about the HTTP response. But I've only seen other services returning a HTTP 200
There was a problem hiding this comment.
as described in the spec it is not the best HTTP citizen. :)
Nicer LNURLp URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks for errors when creating the invoice and logs the error and returns an LNURL error response.
Before it would return a blank pr.
[fixes #21]