Skip to content

Conversation

renuzit
Copy link
Member

@renuzit renuzit commented May 30, 2019

This release includes the following:

  • Added reorg protection to help mitigate 51% attacks
  • Decreased the future block time to 5 minutes to reduce effectiveness of timewarp attacks
  • Upgrade to ZCash version 2.0.5

Release to go live on block 364400

leto and others added 30 commits November 14, 2018 15:02
Co-authored-by: Simon <simon@bitcartel.com>
Dependency Updates

This updates:

- Boost from 1.66.0 to 1.69.0
- OpenSSL From 1.1.0h to 1.1.1a
- Proton from 0.17.0 to 0.26.0
- Rust from 1.28.0 to 1.32.0
Add Sapling benchmarks to benchmark runner

Follow-up to #3611. Once this is merged, we can add the Sapling benchmarks to CI.
Improve some error messages when building a transaction fails

Follow up from #3646
Add missing author aliases

This adds some missing author aliases to release-notes.py.
Port getblockchaininfo.size_on_disk from BTC master

Closes #3630.
redirect and update source docs

also, update Zcash logo source.

User guide related documentation in the `/doc` folder should really live in RTDs. I've left policy and process related docs as is for now.

This **should not** be merged until https://gitlab.com/zcash-docs/zcash-docs/merge_requests/90 is for associated redirect links to work.
zkbot and others added 25 commits May 10, 2019 12:31
 Change expiry delta for migration transactions to 450 blocks

Documentation: to be done as part of the ZIP 308 update (zcash/zips#229).

Test plan: manually check that migration transactions have the expected expiry height, using getrawtransaction $TXID 1.

Closes #3999
Add Logging and persist async operation for Sapling migration

Currently zcashd will automatically remove the last async migration operations when it reaches the height where it sends the transactions it just made. This is not in alignment with other async operations, which are not removed until a node is restarted or a user calls `z_getoperationresult`. This PR removes the calls to pop the operations so that they can be accessed and reviewed later. In this PR I also correct the operation's `amount_migrated` field to exclude the transaction fee (this field existed for debugging purposes, but should be consistent with `z_getmigrationstatus`), and have included the list of migration txids in the operation's result (this is similar to the async rpcs such as `z_sendmany`).

Documentation: none needed.

Test plan:
* After migration transactions have been created, list the opids and call `z_getoperationresult` on them.
* Check that the operations' `amount_migrated` fields exclude the fee.
Let's use the chainparams passed into the function rather than the
static class instance.
Check timestamp is within the allowed 5 minute window to help decrease
effectiveness of timewarp attacks
This commit implements some basic reorg protection by implementing
a rolling 10 block checkpoint. This limits the number of blocks that
a miner can mine in secret to a maximum of 10.
Use the -disablereorgprotection flag to disable reorg protection.
@renuzit renuzit merged commit e864cba into master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.