waddrmgr: encrypt address keys #268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84250d7 to
6c377b2
Compare
|
@jrick I think the encryption is different because of a random nonce. Instead I'm prepending the cryptokey to the address script and hashing the result, thus making sure the key cannot be derived from address alone. |
|
Working on the upgrade path to convert existing keys to the new format. |
68fa258 to
aab5123
Compare
aab5123 to
9286cb7
Compare
9286cb7 to
488cd18
Compare
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Jun 10, 2016
This will allow other tools to call the same prompts, passing these arguments to either the wallet.Create function or to the wallet.Loader type to create a new wallet.
buck54321
added a commit
to buck54321/btcwallet
that referenced
this pull request
May 8, 2024
Remove duplicate NeutrinoClient interface Merge btcsuite#265 cache+neutrino: add new cache module by @Roasbeef Merge btcsuite#261 cache+neutrino: update existing Cache interface to use type parameters by @Roasbeef Merge btcsuite#268 cache: add deletion and iteration methods by @yyforyongyu Merge btcsuite#279 lru: add methods to range with orders by @yyforyongyu Merge btcsuite#278 pushtx: map different backend err to internal err by @ziggie1984 Merge btcsuite#273 query+neutrino: use query dispatcher for GetBlock and GetCFilte by @ellemouton Merge btcsuite#274 multi: introduce a batch filter writer by @ellemouton Merge btcsuite#275 rescan: use batch filter fetching by @ellemouton Merge btcsuite#283 blockmanager.go: use btcd libs to validate headers by @guggero Merge btcsuite#288 neutrino: Added ResetRanking method to PeerRanking by @Chinwendu20 Merge btcsuite#293 & btcsuite#294 Fix typos by @vuittont60 Merge btcsuite#297 query: fix retry query case by @ziggie1984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #242
Still testing out the actual encryption, looks like the encrypted key is different each time.