-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Remove account defaults for wallet requests. #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
conformal-deploy
merged 1 commit into
btcsuite:master
from
jrick:jrick_no_default_accounts
May 1, 2015
Merged
Remove account defaults for wallet requests. #399
conformal-deploy
merged 1 commit into
btcsuite:master
from
jrick:jrick_no_default_accounts
May 1, 2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Apr 23, 2015
Rather than disallowing the default account to be renamed as was proposed in btcsuite#245 (and implemented in btcsuite#246), the default account name is no longer considered a reserved name by the address manager. Instead, it is simply the intial name used for the first initial account. A database upgrade removes any additional aliases for the default account in the database. This prevents a lookup for some name which is not an account name from mapping to the default account unexpectedly (potentially preventing incorrect account usage from the RPC server due to bad iteraction with default parameters). All unset account names in a JSON-RPC request are expected to be set nil by btcjson. This behavior depends on btcsuite/btcd#399. Additionally, the manager no longer considers the wildcard * to be a reserved account name. Due to poor API decisions, the RPC server overloads the meaning of account fields to optionally allow referring to all accounts at a time, or a single account. This is not a address manager responsibility, though, as a future cleaner API should not use multiple differet meanings for the same field across multiple requests. Therefore, don't burden down future APIs with this quirk and prevent incorrect wildcard usage from the RPC server.
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Apr 23, 2015
Rather than disallowing the default account to be renamed as was proposed in btcsuite#245 (and implemented in btcsuite#246), the default account name is no longer considered a reserved name by the address manager. Instead, it is simply the initial name used for the first initial account. A database upgrade removes any additional aliases for the default account in the database. This prevents a lookup for some name which is not an account name from mapping to the default account unexpectedly (potentially preventing incorrect account usage from the RPC server due to bad iteraction with default parameters). All unset account names in a JSON-RPC request are expected to be set nil by btcjson. This behavior depends on btcsuite/btcd#399. Additionally, the manager no longer considers the wildcard * to be a reserved account name. Due to poor API decisions, the RPC server overloads the meaning of account fields to optionally allow referring to all accounts at a time, or a single account. This is not a address manager responsibility, though, as a future cleaner API should not use multiple differet meanings for the same field across multiple requests. Therefore, don't burden down future APIs with this quirk and prevent incorrect wildcard usage from the RPC server.
OK once the deps are in place. |
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Apr 25, 2015
Rather than disallowing the default account to be renamed as was proposed in btcsuite#245 (and implemented in btcsuite#246), the default account name is no longer considered a reserved name by the address manager. Instead, it is simply the initial name used for the first initial account. A database upgrade removes any additional aliases for the default account in the database. This prevents a lookup for some name which is not an account name from mapping to the default account unexpectedly (potentially preventing incorrect account usage from the RPC server due to bad iteraction with default parameters). All unset account names in a JSON-RPC request are expected to be set nil by btcjson. This behavior depends on btcsuite/btcd#399. Additionally, the manager no longer considers the wildcard * to be a reserved account name. Due to poor API decisions, the RPC server overloads the meaning of account fields to optionally allow referring to all accounts at a time, or a single account. This is not a address manager responsibility, though, as a future cleaner API should not use multiple differet meanings for the same field across multiple requests. Therefore, don't burden down future APIs with this quirk and prevent incorrect wildcard usage from the RPC server.
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Apr 28, 2015
Rather than disallowing the default account to be renamed as was proposed in btcsuite#245 (and implemented in btcsuite#246), the default account name is no longer considered a reserved name by the address manager. Instead, it is simply the initial name used for the first initial account. A database upgrade removes any additional aliases for the default account in the database. This prevents a lookup for some name which is not an account name from mapping to the default account unexpectedly (potentially preventing incorrect account usage from the RPC server due to bad iteraction with default parameters). All unset account names in a JSON-RPC request are expected to be set nil by btcjson. This behavior depends on btcsuite/btcd#399. Additionally, the manager no longer considers the wildcard * to be a reserved account name. Due to poor API decisions, the RPC server overloads the meaning of account fields to optionally allow referring to all accounts at a time, or a single account. This is not a address manager responsibility, though, as a future cleaner API should not use multiple differet meanings for the same field across multiple requests. Therefore, don't burden down future APIs with this quirk and prevent incorrect wildcard usage from the RPC server.
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
May 1, 2015
Rather than disallowing the default account to be renamed as was proposed in btcsuite#245 (and implemented in btcsuite#246), the default account name is no longer considered a reserved name by the address manager. Instead, it is simply the initial name used for the first initial account. A database upgrade removes any additional aliases for the default account in the database. This prevents a lookup for some name which is not an account name from mapping to the default account unexpectedly (potentially preventing incorrect account usage from the RPC server due to bad iteraction with default parameters). All unset account names in a JSON-RPC request are expected to be set nil by btcjson. This behavior depends on btcsuite/btcd#399. Additionally, the manager no longer considers the wildcard * to be a reserved account name. Due to poor API decisions, the RPC server overloads the meaning of account fields to optionally allow referring to all accounts at a time, or a single account. This is not a address manager responsibility, though, as a future cleaner API should not use multiple differet meanings for the same field across multiple requests. Therefore, don't burden down future APIs with this quirk and prevent incorrect wildcard usage from the RPC server.
OK (after rebase). |
0d65715
to
1e98e23
Compare
btcwallet will need to check whether these requests were unset, so defaults cannot be automatically filled in by btcjson.
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
May 1, 2015
Rather than disallowing the default account to be renamed as was proposed in btcsuite#245 (and implemented in btcsuite#246), the default account name is no longer considered a reserved name by the address manager. Instead, it is simply the initial name used for the first initial account. A database upgrade removes any additional aliases for the default account in the database. This prevents a lookup for some name which is not an account name from mapping to the default account unexpectedly (potentially preventing incorrect account usage from the RPC server due to bad iteraction with default parameters). All unset account names in a JSON-RPC request are expected to be set nil by btcjson. This behavior depends on btcsuite/btcd#399. Additionally, the manager no longer considers the wildcard * to be a reserved account name. Due to poor API decisions, the RPC server overloads the meaning of account fields to optionally allow referring to all accounts at a time, or a single account. This is not a address manager responsibility, though, as a future cleaner API should not use multiple differet meanings for the same field across multiple requests. Therefore, don't burden down future APIs with this quirk and prevent incorrect wildcard usage from the RPC server. Closes btcsuite#245.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
btcwallet will need to check whether these requests were unset, so defaults cannot be automatically filled in by btcjson.
This currently depends on several unmerged btcwallet PRs so it cannot be merged at this time.ready