Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: btcsuite/btcd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.23.3
Choose a base ref
...
head repository: btcsuite/btcd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.23.4
Choose a head ref
  • 6 commits
  • 6 files changed
  • 3 contributors

Commits on Oct 27, 2022

  1. txscript: modify TweakTaprootPrivKey to operate on private key copy

    In this commit, we fix an inadvertent mutation bug that would at times
    cause the private key passed into the tweak function to actually be
    *modified* in place.
    
    We fix this by accepting the value instead of a pointer. The actual
    private key struct itself contains no pointer fields, so this is
    effectively a deep copy via dereference.
    
    We also add a new unit test that fails w/o this change, to show that the
    private key was indeed being modified.
    Roasbeef committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    fc47c31 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. btcutil/psbt: add method Packet.GetTxFee

    This commit adds a GetTxFee method to the psbt.Packet structure. The method returns the PSBT's fee.
    ffranr committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    586729c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge pull request #1916 from ffranr/add_gettxfee

    btcutil/psbt: add method Packet.GetTxFee
    guggero authored Nov 7, 2022
    1 Configuration menu
    Copy the full SHA
    63835cb View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Merge pull request #1905 from Roasbeef/taptweak-mutation

    txscript: modify TweakTaprootPrivKey to operate on private key copy
    guggero authored Nov 8, 2022
    1 Configuration menu
    Copy the full SHA
    14bb56f View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. btcec/schnorr: use private key copy for BIP-340 signatures

    This is a fix similar to #1905.
    We'll always make a copy of the key in the local scope before passing it
    around elsewhere. Depending on the parity of the public key, the private
    key itself might need to be negated.
    
    A similar test is added here that fails without the patch to the
    signature.go file.
    Roasbeef committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    a8244f5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1919 from Roasbeef/sign-mutate

    btcec/schnorr: use private key copy for BIP-340 signatures
    Roasbeef authored Nov 9, 2022
    1 Configuration menu
    Copy the full SHA
    108fcf7 View commit details
    Browse the repository at this point in the history
Loading