Skip to content

SO-6443: Support JSON formatted log messages via logstash encoder #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 10, 2025
Merged

SO-6443: Support JSON formatted log messages via logstash encoder #1395

merged 6 commits into from
Jul 10, 2025

Conversation

cmark
Copy link
Member

@cmark cmark commented Jul 9, 2025 •
edited
Loading

@cmark cmark self-assigned this Jul 9, 2025
@cmark cmark added the feature label Jul 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.42%. Comparing base (81c1120) to head (770567d).
Report is 9 commits behind head on 9.x.

Additional details and impacted files 
@@            Coverage Diff            @@
##                9.x    #1395   +/-   ##
=========================================
  Coverage     64.42%   64.42%           
+ Complexity    12725    12724    -1     
=========================================
  Files          1614     1614           
  Lines         57392    57392           
  Branches       5639     5639           
=========================================
  Hits          36974    36974           
+ Misses        18063    18061    -2     
- Partials       2355     2357    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cmark cmark marked this pull request as ready for review July 9, 2025 14:31
@cmark cmark requested review from apeteri, AAAlinaaa and adamfilep July 9, 2025 14:31
apeteri
apeteri approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include an example in the form of e.g. a commented appender section in logback.xml?

@cmark
Copy link
Member Author

cmark commented Jul 10, 2025 •
edited
Loading

Should we include an example in the form of e.g. a commented appender section in logback.xml?

Already have it but wanted to finalize and customize it a bit and add it to the docs as well. Will push it sometime today.

Update: see the latest changes for the example config.

@cmark cmark changed the title Support JSON formatted log messages via logstash encoder SO-6443: Support JSON formatted log messages via logstash encoder Jul 10, 2025
AAAlinaaa
AAAlinaaa reviewed Jul 10, 2025
View reviewed changes
@AAAlinaaa AAAlinaaa self-requested a review July 10, 2025 14:02
@cmark cmark merged commit 78e4e16 into 9.x Jul 10, 2025
2 checks passed
@cmark cmark deleted the feature/SO-6443-logstash-encoder branch July 10, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeteri apeteri apeteri approved these changes

@AAAlinaaa AAAlinaaa AAAlinaaa approved these changes

@adamfilep adamfilep adamfilep approved these changes

Assignees

@cmark cmark

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmark @apeteri @AAAlinaaa @adamfilep