Skip to content

SO-6396: fix token refresh for tokens issued by other servers #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

SO-6396: fix token refresh for tokens issued by other servers #1374

merged 1 commit into from
Mar 24, 2025

Conversation

cmark
Copy link
Member

@cmark cmark commented Mar 24, 2025

@cmark
fix(api): token request parameter's issuer claim should match the...
cd458c6 
...server's configured issuer claim value

If not, raise an HTTP 400 Bad Request.
@cmark cmark added the bug label Mar 24, 2025
@cmark cmark requested review from apeteri and nagyo March 24, 2025 14:54
@cmark cmark self-assigned this Mar 24, 2025
apeteri
apeteri approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a note: we will also have to remember to set issuer to use different values in configurations that have multiple JWT configs. Should this be enforced at initialization time?

nagyo
nagyo approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! and +1 for András's comment

@codecov Codecov
Copy link

codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.33%. Comparing base (a1ee920) to head (cd458c6).
Report is 2 commits behind head on 9.x.

Files with missing lines Patch % Lines
...l/core/identity/request/GenerateApiKeyRequest.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                9.x    #1374      +/-   ##
============================================
- Coverage     64.33%   64.33%   -0.01%     
+ Complexity    12699    12697       -2     
============================================
  Files          1614     1614              
  Lines         57372    57376       +4     
  Branches       5645     5646       +1     
============================================
- Hits          36911    36910       -1     
- Misses        18112    18113       +1     
- Partials       2349     2353       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cmark
Copy link
Member Author

cmark commented Mar 24, 2025

LGTM with a note: we will also have to remember to set issuer to use different values in configurations that have multiple JWT configs. Should this be enforced at initialization time?

I think the best would be to rely on the actual deployment ID, like the assigned hostname for example when configuring the service. Something for the devops team 😄

@cmark cmark merged commit 4cfb5f0 into 9.x Mar 24, 2025
3 of 5 checks passed
@cmark cmark deleted the issue/SO-6396-token-refresh-diff-issuer branch March 24, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeteri apeteri apeteri approved these changes

@nagyo nagyo nagyo approved these changes

Assignees

@cmark cmark

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmark @apeteri @nagyo