Skip to content

SO-6375: read alias for browser permission operation #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 11, 2025
Merged

SO-6375: read alias for browser permission operation #1361

merged 6 commits into from
Feb 11, 2025

Conversation

cmark
Copy link
Member

@cmark cmark commented Feb 11, 2025

No description provided.

cmark added 4 commits February 11, 2025 13:13
@cmark
feat(core): introduce read permission operation
5fb63b8 
This is an alias to the `browse` operation type.
@cmark
chore(core): migrate all read requests to use read operation type...
4e89651 
...instead of browse
@cmark
test(core): update tests to use read operation type instead of browse
f2ed74d 
Add one extra test to verify that the former browse operation type still
working as a backward compatible operation type.
@cmark
chore(core): add formatted runtime exception sc to init exception type
5a158d4
@cmark cmark requested review from apeteri and AAAlinaaa February 11, 2025 13:13
@cmark cmark self-assigned this Feb 11, 2025
apeteri
apeteri approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@apeteri apeteri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.11%. Comparing base (265238d) to head (493c2c1).
Report is 7 commits behind head on 9.x.

Files with missing lines Patch % Lines
...tional/snowowl/core/branch/SearchMergeRequest.java 0.00% 1 Missing ⚠️
...om/b2international/snowowl/core/identity/User.java 0.00% 0 Missing and 1 partial ⚠️
...ional/snowowl/core/repository/OptimizeRequest.java 0.00% 1 Missing ⚠️
...tore/request/EvaluateQueryRefSetMemberRequest.java 0.00% 1 Missing ⚠️
.../datastore/request/EvaluateQueryRefSetRequest.java 0.00% 1 Missing ⚠️
.../reasoner/request/ClassificationSearchRequest.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                9.x    #1361   +/-   ##
=========================================
  Coverage     64.10%   64.11%           
- Complexity    12624    12627    +3     
=========================================
  Files          1614     1614           
  Lines         57334    57336    +2     
  Branches       5637     5638    +1     
=========================================
+ Hits          36755    36759    +4     
  Misses        18233    18233           
+ Partials       2346     2344    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmark cmark merged commit 32db033 into 9.x Feb 11, 2025
5 checks passed
@cmark cmark deleted the improvement/SO-6375-read-alias-permission-op branch February 11, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeteri apeteri apeteri approved these changes

@AAAlinaaa AAAlinaaa AAAlinaaa approved these changes

Assignees

@cmark cmark

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmark @apeteri @AAAlinaaa