fix(snomed): improve performance of component inactivation... #1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by skipping existing historical association member search for a given inactivated component when there is no historical reference set identifier present in the current semantic network (memberOf fields). Also, caching the current association reference set IDs in the scope of the request, so these can be reused which improves performance for those components where there are existing assoc. members.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1350 +/- ##
============================================
+ Coverage 63.69% 63.71% +0.01%
- Complexity 12535 12541 +6
============================================
Files 1613 1614 +1
Lines 57218 57245 +27
Branches 5629 5633 +4
============================================
+ Hits 36445 36472 +27
+ Misses 18421 18420 -1
- Partials 2352 2353 +1 ☔ View full report in Codecov by Sentry. |
apeteri
approved these changes
Nov 28, 2024
...src/com/b2international/snowowl/snomed/datastore/request/SnomedAssociationReferenceSets.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by skipping existing historical association member search for a given inactivated component when there is no historical reference set identifier present in the current semantic network (memberOf fields).
Also, caching the current association reference set IDs in the scope of the request, so these can be reused which improves performance for those components where there are existing assoc. members.