SO-6339: improve authorized context propagation #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... SearchPageableCollectionResourceRequestBuilder Prefer using the context variant when there is a context available otherwise ensure that callers always supply the necessary request headers so that they are not failing with Missing authorization token exception when the initiating request was already successfully authenticated. Fixes https://snowowl.atlassian.net/browse/SO-6339
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1346 +/- ##
============================================
- Coverage 63.67% 63.67% -0.01%
- Complexity 12523 12524 +1
============================================
Files 1612 1612
Lines 57120 57126 +6
Branches 5622 5622
============================================
+ Hits 36373 36376 +3
- Misses 18397 18401 +4
+ Partials 2350 2349 -1 ☔ View full report in Codecov by Sentry. |
AAAlinaaa
reviewed
Nov 25, 2024
| } | ||
|
|
||
| public final Stream<R> streamAsync(IEventBus bus, Map<String, String> headers, Function<B, AsyncRequest<R>> req) { | ||
| return Streams.stream(new SearchResourceRequestIterator<B, R>(getSelf(), (builder) -> req.apply(builder).withHeaders(headers).execute(bus).getSync(3, TimeUnit.MINUTES))); |
There was a problem hiding this comment.
Can we document these timeouts?
There was a problem hiding this comment.
Somewhere yes, but that requires a bit more effort and there are a couple of these lying around in the code. Most of them are around 3 minutes. Probably we need to extract them into a static/dynamic config value. Will create a Jira for it.
AAAlinaaa
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with async streaming contexts the system was unable to propagate authorization information to the sub-request which was resulted in an error. This PR fixes that.
Jira: https://snowowl.atlassian.net/browse/SO-6339