-
Notifications
You must be signed in to change notification settings - Fork 33
Improve compatibility with BCP-47 language tags #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...expanding methods in FhirRequest
...designations in FhirCodeSystemLookupConverter: add separators to returned language tags if needed
...language code in their "language" property; move language reference set information ot the "designation-use-context" extension in SnomedFhirCodeSystemLookupConverter.
...implicit value sets, leave the expansion step to a dedicated SnomedFhirValueSetExpander class. This allows us to include the same level of information for designations as in SNOMED CT lookup operations.
...FhirCodeSystemLookupRequest before passing it to a native request
...FhirCodeSystemValidateCodeRequest before passing it to a native request
...parameter in FHIR operation controllers; the property is marked as optional and the default value will be filled in when the request corresponding to the operation is executed.
- SnomedDescription instances might not have the "languageCode" field populated (a similar code snippet exists in SnomedConceptSearchRequestEvaluator) - The new FHIR model creates empty instances in some places where the previous model returned null; the fix is to use "hasXYZ()" instead of "getXYZ() == null" when checking the presence of a property.
...extensions in CodeSystem$lookup and ValueSet$expand test cases
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1339 +/- ##
============================================
+ Coverage 63.62% 63.69% +0.06%
- Complexity 12494 12524 +30
============================================
Files 1611 1613 +2
Lines 57027 57190 +163
Branches 5602 5628 +26
============================================
+ Hits 36286 36427 +141
- Misses 18402 18412 +10
- Partials 2339 2351 +12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:🍏
...wowl.fhir.core/src/com/b2international/snowowl/fhir/core/request/codesystem/FhirRequest.java
Show resolved
Hide resolved
...wowl.snomed.fhir/src/com/b2international/snowowl/snomed/fhir/SnomedFhirValueSetExpander.java
Show resolved
Hide resolved
...expansion utility methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥓
This PR introduces the following changes:
CodeSystem$lookup
converter e19ed44