Skip to content

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Nov 8, 2024

This PR introduces the following changes:

  • Transparently "compact" and "expand" a language tag in the FHIR request boundary (Snow Owl's internal requests will still work with private use extensions containing a complete language reference set ID – these can be changed later if required but will have a larger effect on the code base) 16d3021
  • Use the split private use extension when returning designations in the default CodeSystem$lookup converter e19ed44
  • Use the most recently described behavior in IHTSDO Confluence: use the language code only and add an extension for SNOMED CT lookup operations 058c769
  • Split SNOMED CT implicit VS support into a part that creates the virtual value set and another part that evaluates it; as this is now tooling-dependent, the same extension mechanism can be applied to the expanded concept designations 2f9b82b
  • Compact "in" parameters that carry a language tag c5c91a4, 9669f70, eabed89

...designations in FhirCodeSystemLookupConverter: add separators to
returned language tags if needed
...language code in their "language" property; move language reference
set information ot the "designation-use-context" extension in
SnomedFhirCodeSystemLookupConverter.
...implicit value sets, leave the expansion step to a dedicated
SnomedFhirValueSetExpander class. This allows us to include the same
level of information for designations as in SNOMED CT lookup operations.
...FhirCodeSystemLookupRequest before passing it to a native request
...FhirCodeSystemValidateCodeRequest before passing it to a native
request
...parameter in FHIR operation controllers; the property is marked as
optional and the default value will be filled in when the request
corresponding to the operation is executed.
- SnomedDescription instances might not have the "languageCode" field
populated (a similar code snippet exists in
SnomedConceptSearchRequestEvaluator)
- The new FHIR model creates empty instances in some places where the
previous model returned null; the fix is to use "hasXYZ()" instead of
"getXYZ() == null" when checking the presence of a property.
...extensions in CodeSystem$lookup and ValueSet$expand test cases
@apeteri apeteri requested review from cmark and adamfilep November 8, 2024 09:07
@apeteri apeteri self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 81.13208% with 40 lines in your changes missing coverage. Please review.

Project coverage is 63.69%. Comparing base (dd21d60) to head (bf40e84).
Report is 27 commits behind head on 9.x.

Files with missing lines Patch % Lines
...wowl/fhir/core/request/codesystem/FhirRequest.java 4.16% 21 Missing and 2 partials ⚠️
...nowowl/snomed/fhir/SnomedFhirValueSetExpander.java 90.47% 1 Missing and 7 partials ⚠️
...uest/codesystem/FhirCodeSystemLookupConverter.java 0.00% 7 Missing ⚠️
.../codesystem/FhirCodeSystemValidateCodeRequest.java 93.75% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1339      +/-   ##
============================================
+ Coverage     63.62%   63.69%   +0.06%     
- Complexity    12494    12524      +30     
============================================
  Files          1611     1613       +2     
  Lines         57027    57190     +163     
  Branches       5602     5628      +26     
============================================
+ Hits          36286    36427     +141     
- Misses        18402    18412      +10     
- Partials       2339     2351      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@adamfilep adamfilep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:🍏

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark merged commit 70ce83a into 9.x Nov 25, 2024
5 checks passed
@cmark cmark deleted the issue/SO-6076-language-tag-support branch November 25, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants