Skip to content

Conversation

cmark
Copy link
Member

@cmark cmark commented Oct 14, 2024

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 49.10714% with 57 lines in your changes missing coverage. Please review.

Project coverage is 63.68%. Comparing base (db73971) to head (00ae313).
Report is 13 commits behind head on 9.x.

Files with missing lines Patch % Lines
...nowowl/fhir/rest/FhirResourceSearchParameters.java 41.46% 24 Missing ⚠️
...l/snowowl/core/rest/PreferHandlingInterceptor.java 56.09% 8 Missing and 10 partials ⚠️
...onal/snowowl/fhir/rest/AbstractFhirController.java 55.55% 4 Missing ⚠️
...international/snowowl/fhir/rest/FhirMediaType.java 50.00% 4 Missing ⚠️
...wl/fhir/rest/FhirCodeSystemSubsumesController.java 0.00% 2 Missing ⚠️
...l/fhir/rest/FhirConceptMapTranslateController.java 0.00% 2 Missing ⚠️
.../fhir/rest/FhirValueSetValidateCodeController.java 0.00% 2 Missing ⚠️
...hir/rest/FhirCodeSystemValidateCodeController.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1336      +/-   ##
============================================
+ Coverage     63.63%   63.68%   +0.04%     
- Complexity    12497    12517      +20     
============================================
  Files          1611     1612       +1     
  Lines         57027    57106      +79     
  Branches       5602     5622      +20     
============================================
+ Hits          36289    36367      +78     
+ Misses        18401    18391      -10     
- Partials       2337     2348      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@apeteri apeteri marked this pull request as ready for review October 22, 2024 20:31
@cmark cmark requested a review from apeteri November 6, 2024 12:31
@cmark cmark assigned nagyo and adamfilep and unassigned nagyo and adamfilep Nov 6, 2024
@cmark cmark requested review from nagyo and adamfilep November 6, 2024 12:32
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member Author

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (non-binding 😄)

@cmark cmark merged commit 742257d into 9.x Nov 20, 2024
4 of 5 checks passed
@cmark cmark deleted the feature/rfc7240-prefer-header branch November 20, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants