Skip to content

Conversation

cmark
Copy link
Member

@cmark cmark commented Sep 20, 2024

cmark added 30 commits April 17, 2024 16:24
Keep serializer/deserializer classes and extracted some additional logic
to other types.
Add some needed models from the official
org.hl7.fhir.r4.model.codesystems package.
...property values

Previously this was defined in enumeration types.
@cmark cmark requested review from apeteri and nagyo September 20, 2024 14:10
@cmark cmark self-assigned this Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 60.83916% with 56 lines in your changes missing coverage. Please review.

Project coverage is 63.67%. Comparing base (7cca5aa) to head (dca22be).
Report is 94 commits behind head on 9.x.

Files with missing lines Patch % Lines
...nternational/snowowl/fhir/core/R5ObjectFields.java 69.56% 21 Missing ⚠️
...wowl/fhir/core/exceptions/ValidationException.java 0.00% 14 Missing ⚠️
...ernational/snowowl/fhir/core/FhirModelHelpers.java 45.45% 10 Missing and 2 partials ⚠️
...al/snowowl/fhir/core/exceptions/FhirException.java 84.37% 4 Missing and 1 partial ⚠️
...src/com/b2international/snowowl/core/Resource.java 0.00% 1 Missing ⚠️
...nternational/snowowl/core/TerminologyResource.java 0.00% 1 Missing ⚠️
...com/b2international/snowowl/fhir/core/Summary.java 0.00% 1 Missing ⚠️
...wowl/fhir/core/exceptions/BadRequestException.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##                9.x    #1323       +/-   ##
=============================================
+ Coverage     48.57%   63.67%   +15.10%     
+ Complexity    14073    12463     -1610     
=============================================
  Files          1950     1609      -341     
  Lines         95449    56791    -38658     
  Branches      11028     5602     -5426     
=============================================
- Hits          46363    36161    -10202     
+ Misses        46049    18291    -27758     
+ Partials       3037     2339      -698     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Notes from off-PR discussion are added below.

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@cmark cmark merged commit 593acca into 9.x Oct 3, 2024
5 checks passed
@cmark cmark deleted the improvement/migrate-to-fhir-core branch October 3, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants