-
Notifications
You must be signed in to change notification settings - Fork 33
Migrate FHIR modules to use official HL7 FHIR libraries #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Keep serializer/deserializer classes and extracted some additional logic to other types.
...to HL7 FHIR model
...to HL7 FHIR model
...to lookup result parameters
...to HL7 FHIR model
Add some needed models from the official org.hl7.fhir.r4.model.codesystems package.
...property values Previously this was defined in enumeration types.
...FhirCodeSystemLookupConverter interface and SNOMED CT impl.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1323 +/- ##
=============================================
+ Coverage 48.57% 63.67% +15.10%
+ Complexity 14073 12463 -1610
=============================================
Files 1950 1609 -341
Lines 95449 56791 -38658
Branches 11028 5602 -5426
=============================================
- Hits 46363 36161 -10202
+ Misses 46049 18291 -27758
+ Partials 3037 2339 -698 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Notes from off-PR discussion are added below.
...l.fhir.core/src/com/b2international/snowowl/fhir/core/request/FhirResourceSearchRequest.java
Show resolved
Hide resolved
...r.core/src/com/b2international/snowowl/fhir/core/request/bundle/FhirBundleSearchRequest.java
Show resolved
Hide resolved
...rc/com/b2international/snowowl/fhir/core/request/codesystem/FhirCodeSystemLookupRequest.java
Show resolved
Hide resolved
...l.fhir.core/src/com/b2international/snowowl/fhir/core/request/FhirResourceSearchRequest.java
Outdated
Show resolved
Hide resolved
...re/src/com/b2international/snowowl/fhir/core/request/codesystem/FhirValidateCodeRequest.java
Outdated
Show resolved
Hide resolved
...FhirCodeSystemValidateCodeRequest
Add getSystemWithoutOidPrefix helper for CanonicalTypes.
...re/src/com/b2international/snowowl/fhir/core/request/valueset/FhirValueSetExpandRequest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
https://snowowl.atlassian.net/browse/SO-6080