-
-
Notifications
You must be signed in to change notification settings - Fork 912
docs: add CLI docs under tools content bucket #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1097--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay! nice job so far! thank you for taking care of that so quickly 🙌🏽🙌🏽🙌🏽
We need to have another technical feedback review by @derberg before we can merge tho, so now we wait for him 😄✌🏽
@alequetzalli thank you for your compliments. I was only able to complete the task so quickly because of your well detailed and timely feedbacks. It's been a pleasure working with you on this, and I'm looking forward to working with you on a new task once this current one is completed. |
It looks good. My only concern is that it is CLI docs authored in |
@alequetzalli I mean we need docs under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @activus-d, kindly update the GoBack
button on /docs/guides
page to point it to the new AsyncAPI CLI page created by you.
@akshatnema Thanks for the Observation. The branch has been updated. |
Hey @activus-d here is what you need to do:
I realize this is a lot of extra steps to think about, so please let us know if you understand and if you're able to do next steps. 😄✌🏽 |
Not quite, that is not what the Concepts sections is for and you should not duplicate content buckets into sub-sections. Instead, the CLI tool will be introduced in the first file of |
oh, sorry, by |
@alequetzalli Alright. However, you are yet to tell me which of the directories in the CLI repository would host the documents. Is it that I will create a new folder at the root of the repository and name it (let's say docs)? I need a specific direction in this regard. |
@activus-d yes, new |
@derberg @alequetzalli I will work on it and make a pull request soon. |
@alequetzalli @derberg the pull request has been made as instructed. Kindly review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey folks, should not this PR be closed in favour of the one from CLI?
CLOSING in favor of resolving via asyncapi/cli#414 |
This Pull Request creates the AsyncAPI CLI content under the Tools content bucket by re-writing and editing what is currently in the CLI readME docs. This resolves issue #1078