Skip to content

Conversation

meeseeksmachine
Copy link

Backport PR #18374: Bump OpenAstronomy/github-actions-workflows from 1.16.0 to 2.1.0 in /.github/workflows in the actions group

…s from 1.16.0 to 2.1.0 in /.github/workflows in the actions group
@lumberbot-app lumberbot-app bot added this to the v7.1.1 milestone Jul 1, 2025
@lumberbot-app lumberbot-app bot added testing Release no-changelog-entry-needed Build all wheels Run all the wheel builds rather than just a selection dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code backport-v7.1.x on-merge: backport to v7.1.x labels Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim merged commit c9bc67e into astropy:v7.1.x Jul 1, 2025
60 of 64 checks passed
@neutrinoceros
Copy link
Contributor

@pllim backporting this without a release note isn't ideal in my opinion. See #18159 (comment)

@pllim
Copy link
Member

pllim commented Jul 2, 2025

Oh ooops sorry! Do you have a preference? Should be no problem to revert but it does bloat up the history if you plan to add it back in anyway. Would adding a note make more sense at this point? Hope you can advise. Thanks!

@neutrinoceros
Copy link
Contributor

#18159 has that note, I think it makes sense to backport it too, if you agree to it. I just want us to coordinate the move before I change #18159 (the note was originally meant for 7.2.0)

@pllim
Copy link
Member

pllim commented Jul 2, 2025

OK let's talk there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.1.x on-merge: backport to v7.1.x Build all wheels Run all the wheel builds rather than just a selection dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code no-changelog-entry-needed Release testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants