Skip to content

[flake8_django] Fix DJ008 false positive for abstract models with type-annotated abstract field #19221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

[flake8_django] Fix DJ008 false positive for abstract models with type-annotated abstract field #19221

merged 2 commits into from
Jul 11, 2025

Conversation

danparizher
Copy link
Contributor

Summary

Fixes #19154

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added bug Something isn't working rule Implementing or modifying a lint rule labels Jul 11, 2025
MichaReiser
MichaReiser approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MichaReiser MichaReiser enabled auto-merge (squash) July 11, 2025 16:48
@MichaReiser MichaReiser merged commit ee88abf into astral-sh:main Jul 11, 2025
34 checks passed
@CarrotManMatt
Copy link
Contributor

Thanks for the quick fix!

@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
bug Something isn't working rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DJ008 incorrectly reporting missing __str__ method for abstract class with type annotations
3 participants
@danparizher @CarrotManMatt @MichaReiser